Main Menu

Ice TV Kodi Add-on

Started by DeltaMikeCharlie, November 21, 2023, 05:27:03 PM

Previous topic - Next topic

DeltaMikeCharlie

1) I was experimenting with the Ice TV Kodi addon over the weekend and I found that regardless of the host name that I provided during the LibreELEC portion of the setup process, the device was always named 'IceBox' under 'My Recorders' on the ICE web site.

After a quick search, I found that in 'icetv.py' in the 'login_via_setup_wizard()' function, the device label seems to be hard-coded rather than using the Linux host name (uname -n).

    if (region > 0):
        data = {'member': {'email_address': email_address,
                           'password': password,
                           'region_id': region},
                'device': {'uid': mac_address,
                           'label': 'IceBox',   <====== Hard-coded
                           'type_id': 40}}
    else:
        data = {'member': {'email_address': email_address,
                           'password': password},
                'device': {'uid': mac_address,
                           'label': 'IceBox',   <====== Hard-coded
                           'type_id': 40}}

Perhaps this is not the right area of the code, however, there are a number of Python calls that can get the hostname.


2) I also noticed that the addon is hard-coded to use 'service.tvheadend42'.  LibreELEC are currently working on 'tvheadend43'.  It might be handy to search for the loaded Kodi services and match any version of TVH.


3) Are there any plans to release this addon (or a variation thereof) as a generic Kodi-installable addon?

prl

device[label] is where the device name is passed to IceTV in the Beyonwiz IceTV plugin (it defaults to the "Beyonwiz modelname" on Beyonwizes, e.g. "Beyonwiz T2"), but it can be changed under user control on the device or on the IceTV Web page in My Account>My Recorders. The Beyonwiz code doesn't use the hostname.

Having it hardcoded would make it hard for someone to use two IceBoxes on the same account. I'm not sure what would happen with the IceBox if you changed the name on the IceTV Web page (server side).
Peter
Beyonwiz T4 in-use
Beyonwiz T2, T3, T4, U4 & V2 for testing

Daniel Hall at IceTV

1. This is on the list of things to do, just working on some upgrades to the setup now, then a timer issue.

2. We specifically chose 4.2 as it's a 'stable' release and my understanding is that 4.3 is an alpha from tvheadend until the next stable release of 4.4 (which of course has no timeline at all)

3. Possibly, it's something we have discussed, but no firm plans as yet.
Regards,

Daniel.
CTO.

DeltaMikeCharlie

Quote from: prl on November 22, 2023, 09:02:51 AMHaving it hardcoded would make it hard for someone to use two IceBoxes on the same account.
Yes, I ended up with 3, all called 'IceBox'.  I had to carefully identify my actual IceBox before moving forward.

Quote from: prl on November 22, 2023, 09:02:51 AMI'm not sure what would happen with the IceBox if you changed the name on the IceTV Web page (server side).
I renamed one via 'My Recorders' and it did not seem to have any side effects.  Admittedly, I did not do a thorough test of functionality, just enough to see if my experiment worked (it did not).

DeltaMikeCharlie

Thanks for the update Daniel.

Quote from: Daniel Hall at IceTV on November 22, 2023, 09:16:21 AM2. We specifically chose 4.2 as it's a 'stable' release and my understanding is that 4.3 is an alpha from tvheadend until the next stable release of 4.4 (which of course has no timeline at all)
I was told on the TVH forum that they had effectively abandoned numbered releases as the main branch seems to be 'pretty stable' as well as a chronic lack of resources.

I have recently made some commits to TVH and I was testing to see if they worked OK on an IceBox.  I built my own LibreELEC from scratch and created a new package that I called 'tvheadend99'.  This new package pointed directly to my un-merged GitHub repository branch.

LibreELEC built OK and installed/ran OK on my BYOD hardware.  I hacked the ICE add-on to expect TVH version 99.9.9.0 and that's where the faecal matter impacted the air movement device.  I do plan to return to my experimentation once I have had time to reassess the current situation.

IanL-S

I also rename my IceBox on the IceTV www site. Have done so since before public release. Having two devices with the same name can be very confusing as I found last week when I took my second BYOB IceBox out of mothballs. Had forgotten to check that I had renamed the IceBox already on the account.
IceTV: IceBox + BYOB IceBox + 2xTRF-2400 + 2xTF7100HDPVRtPlus + SKIPPA [RIP] + T2 + U4 + V2
No IceTV: a few Toppys and T2
Synology NAS
Check out the oztoppy wiki and oztoppy Forum for Toppy help

MD

The name can be changed on the customer account "My Recorders" section and it will reflect throughout their account, but will remain IceBox within LibreELEC on the device.

Daniel Hall at IceTV

Quote from: DeltaMikeCharlie on November 22, 2023, 10:16:49 AMI was told on the TVH forum that they had effectively abandoned numbered releases as the main branch seems to be 'pretty stable' as well as a chronic lack of resources.

I have recently made some commits to TVH and I was testing to see if they worked OK on an IceBox.  I built my own LibreELEC from scratch and created a new package that I called 'tvheadend99'.  This new package pointed directly to my un-merged GitHub repository branch.

LibreELEC built OK and installed/ran OK on my BYOD hardware.  I hacked the ICE add-on to expect TVH version 99.9.9.0 and that's where the faecal matter impacted the air movement device.  I do plan to return to my experimentation once I have had time to reassess the current situation.

Sounds like something we can revisit in the future then, just have a few things to get through first.
Regards,

Daniel.
CTO.

DeltaMikeCharlie

Quote from: Daniel Hall at IceTV on November 22, 2023, 11:08:27 AM
Quote from: DeltaMikeCharlie on November 22, 2023, 10:16:49 AMI was told on the TVH forum that they had effectively abandoned numbered releases as the main branch seems to be 'pretty stable' as well as a chronic lack of resources.
Sounds like something we can revisit in the future then, just have a few things to get through first.
Perfectly understandable.  Here is the thread that I referred to.
https://tvheadend.org/boards/5/topics/50181